Add <bs>, <wait5>, <wait10>, <del> special keys (Packerisms) #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since we are using regexp we could handle the 1.9.3-p547 :001 > /<wait(.*)>/ =~ "<wait>"
=> 0
1.9.3-p547 :002 > $1
=> ""
1.9.3-p547 :003 > /<wait(.*)>/ =~ "<wait5>"
=> 0
1.9.3-p547 :004 > $1
=> "5" |
|
and great that you are working on making us closer to packer - want to add support for it's templates soon |
|
👍 ok let me think about this.. could be dangerous but maybe your idea will work. |
|
you can always do |
|
Yes I was thinking of using |
|
hey, any progress? need help with that? or should I merge and add the regexp thing? |
|
Sorry, I'll get back to this on the weekend. |
|
thanks |
|
oh the weekend past, let me know if you still want to work on the improvement or if I should finish it. |
mpapis
added a commit
that referenced
this pull request
Oct 23, 2014
Add <bs>, <wait5>, <wait10>, <del> special keys (Packerisms)
mpapis
added a commit
that referenced
this pull request
Oct 23, 2014
|
and added the matching, let me know how it works for you (... my vbox just died) |
mpapis
added a commit
that referenced
this pull request
Nov 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a lot of people doing crazy hacks like:
'<Wait>'*5in their templates. This PR steals some good features from Packer, such as<Wait5>and<Wait10>.I also added some other special keys to match-up with what's available in Packer templates.